Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dweb:/ipfs/$cid not detected on Android #348

Open
jefft0 opened this issue Dec 27, 2017 · 7 comments
Open

dweb:/ipfs/$cid not detected on Android #348

jefft0 opened this issue Dec 27, 2017 · 7 comments
Assignees
Labels
area/android Issues related to Android status/blocked/upstream-bug Blocked by upstream bugs status/blocked Unable to be worked further until needs are met status/deferred Conscious decision to pause or backlog

Comments

@jefft0
Copy link

jefft0 commented Dec 27, 2017

I have Firefox for Android 57.0.1 and IPFS companion 2.1.0. IPFS-like paths (/ipfs/$cid) are not redirected. (Are they supposed to be in this version?) (The same link redirect correctly in Firefox for Desktop.)

@lidel lidel added the status/blocked/missing-api Blocked by missing API label Dec 27, 2017
@lidel
Copy link
Member

lidel commented Dec 27, 2017

Yeah it seems the hack from #164 (comment) does not work on Android:

Can't do anything about it at this time – Firefox is lacking APIs (#164).
Rewrites of href and src attributes in HTML should still work tho.

@lidel lidel changed the title /ipfs/$cid ot detected on Android dweb:/ipfs/$cid not detected on Android Dec 27, 2017
@jefft0
Copy link
Author

jefft0 commented Dec 27, 2017

OK, thanks. You're aware of the problem. Is there another issue I can track for Android support? If so, you can close this issue.

@lidel
Copy link
Member

lidel commented Dec 27, 2017

I think for protocol support you can just follow #164, this will be addressed there.
Other things should work on Android.

If not, please create separate issue for each problem you find on Android – we don't have robust test suite yet (#145) so such feedback is very much appreciated 👍

@lidel lidel closed this as completed Dec 27, 2017
@lidel
Copy link
Member

lidel commented Jan 6, 2018

Reopening due to development described in #164 (comment)

@lidel lidel reopened this Jan 6, 2018
@lidel lidel added the status/blocked/upstream-bug Blocked by upstream bugs label Jan 6, 2018
@cvan
Copy link

cvan commented Mar 7, 2018

Apologies if I'm misunderstanding here. Just wanted to confirm: since https://bugzilla.mozilla.org/show_bug.cgi?id=1428446 has been merged and shipped (woo!), this issue will be moot when PR #359 is merged? Or is there another Firefox (for Android) bug to track here?

@lidel lidel self-assigned this Mar 7, 2018
@lidel lidel added the status/in-progress In progress label Mar 7, 2018
@lidel
Copy link
Member

lidel commented Mar 7, 2018

Yes, this will be closed when PR #359 is merged :)

@lidel
Copy link
Member

lidel commented Mar 15, 2018

I just smoke-tested latest master. Actually, while extension loads fine in Firefox for Android (v59 from Beta channel), it seems to be missing the UI for picking which extension should be a handler for dweb protocol.

Filled an upstream bug:

@lidel lidel removed the status/blocked/missing-api Blocked by missing API label Mar 15, 2018
@lidel lidel added status/deferred Conscious decision to pause or backlog and removed status/in-progress In progress labels Sep 22, 2018
@jessicaschilling jessicaschilling added the status/blocked Unable to be worked further until needs are met label Mar 30, 2020
@lidel lidel added the area/android Issues related to Android label Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/android Issues related to Android status/blocked/upstream-bug Blocked by upstream bugs status/blocked Unable to be worked further until needs are met status/deferred Conscious decision to pause or backlog
Projects
No open projects
Status: Needs Grooming
Development

No branches or pull requests

4 participants