Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration to JS API with Async Await and Async Iterables #843

Closed
alanshaw opened this issue Feb 10, 2020 · 0 comments · Fixed by #811
Closed

Migration to JS API with Async Await and Async Iterables #843

alanshaw opened this issue Feb 10, 2020 · 0 comments · Fixed by #811
Assignees
@lidel
Labels
area/window-ipfs Issues related to IPFS API exposed on every page effort/days Estimated to take multiple days, but less than a week Epic exp/expert Having worked on the specific codebase is important kind/maintenance Work required to avoid breaking changes or harm to project's status quo P0 Critical: Tackled by core team ASAP
Milestone
v2.15

Comments

@alanshaw
Copy link
Member

👋 hey, a new js-ipfs release is coming soon \o/

It's a big release with breaking API changes, please check the release issue for all the info you need. There's also a migration guide to help you to migrate your code to the new API and a blog post explaining the changes and motivations behind them.

Unfortunately, the tests for your application failed when they were run with the latest release candidate (0.41.0-rc.0). Do not worry, this was very likely considering the magnitude of the changes! Please consult the release info, it should have everything you need to be able to upgrade, and if you're still having problems then please reply to this issue and we'll get you sorted ASAP!

Aside from that, have fun with this release, we're really excited about this one and the possibilities it brings to our users! ❤️
@alanshaw alanshaw mentioned this issue Feb 10, 2020
Closed
57 tasks
@lidel lidel added the kind/maintenance Work required to avoid breaking changes or harm to project's status quo label Feb 14, 2020
@lidel lidel mentioned this issue Mar 4, 2020
Closed
@lidel lidel mentioned this issue Apr 3, 2020
Closed
@lidel lidel changed the title preparations for js-ipfs 0.41 Migration to JS API with Async Await and Async Iterables Apr 3, 2020
@lidel lidel added Epic area/window-ipfs Issues related to IPFS API exposed on every page exp/expert Having worked on the specific codebase is important effort/days Estimated to take multiple days, but less than a week P0 Critical: Tackled by core team ASAP labels Apr 3, 2020
@lidel lidel self-assigned this Apr 3, 2020
@lidel lidel mentioned this issue Apr 5, 2020
Merged
3 tasks
lidel added a commit that referenced this issue Apr 5, 2020
@lidel
fix: stop injecting window.ipfs for now
861bb2f 
This force-disables injection of window.ipfs and fades out the
experiments on Preferences screen.

We will restore it after move to JS API with Async Await and Async
Iterables is finished.

Context:
#852 (comment)
#843
@lidel lidel pinned this issue Apr 5, 2020
lidel added a commit that referenced this issue Apr 5, 2020
@lidel
fix: webui in embedded js-ipfs in Brave
f473cfd 
When user opts-in to embedded js-ipfs experiment in Brave
we use precached webui loaded from gateway port.

In the future we will load /webui from API port, but that requires
#843 to land first
@lidel lidel mentioned this issue Apr 7, 2020
Closed
This was referenced Apr 21, 2020
Closed
Merged
@BubuAnabelas BubuAnabelas mentioned this issue Jun 10, 2020
Open
@lidel lidel added this to the v2.15 milestone Sep 6, 2020
@lidel lidel closed this as completed in #811 Oct 5, 2020
@lidel lidel unpinned this issue Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidel lidel

Labels
area/window-ipfs Issues related to IPFS API exposed on every page effort/days Estimated to take multiple days, but less than a week Epic exp/expert Having worked on the specific codebase is important kind/maintenance Work required to avoid breaking changes or harm to project's status quo P0 Critical: Tackled by core team ASAP
Projects
None yet
Milestone
v2.15
Development

Successfully merging a pull request may close this issue.

refactor: the async await extravaganza ipfs/ipfs-companion
2 participants
@alanshaw @lidel