Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: IpfsApiAccessError #458

Merged
merged 8 commits into from
Apr 30, 2018
Merged

Feat: IpfsApiAccessError #458

merged 8 commits into from
Apr 30, 2018

Commits on Apr 25, 2018

  1. feat: create and use IpfsApiAccessError

    @JonKrone
    JonKrone committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    237cffb View commit details
    Browse the repository at this point in the history

  2. test: Test that a well-formed IpfsApiAccessError is thrown when user … 

    …denies permission
    @JonKrone
    JonKrone committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    5f9cd07 View commit details
    Browse the repository at this point in the history

  3. doc: Update example checking for access denied errors.

    @JonKrone
    JonKrone committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    5b0e442 View commit details
    Browse the repository at this point in the history

  4. fix: make tests work on windows 

    Tests were not running because some path parser didn't understand
apostrophes so I've just converted those to escaped quotes.

Some pre-mfs-scope tests failed because path.join presumes we want paths
for the current running OS. I changed it to always use posix paths but
I'm open to arguments that changing the implementation is a better
approach. All of our target environments use posix paths, I believe.
    @JonKrone
    JonKrone committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    4181d53 View commit details
    Browse the repository at this point in the history

  5. feat: refactor api-access error

    @JonKrone
    JonKrone committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    cf4241d View commit details
    Browse the repository at this point in the history

  6. feat: use path-browserify instead of builtin path.

    @JonKrone
    JonKrone committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    ce7e71a View commit details
    Browse the repository at this point in the history

  7. fix: update yarn lock file.

    @JonKrone
    JonKrone committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    73eb7cc View commit details
    Browse the repository at this point in the history

  8. feat: update console.log in window.ipfs error example

    @JonKrone
    JonKrone committed Apr 25, 2018
    Configuration menu
    Copy the full SHA
    a840622 View commit details
    Browse the repository at this point in the history