Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix random UI glitches: check only for recursive pins #594

Merged
merged 1 commit into from
Sep 24, 2018
Merged

Fix random UI glitches: check only for recursive pins #594

merged 1 commit into from
Sep 24, 2018

Conversation

lidel
Copy link
Member

@lidel lidel commented Sep 22, 2018

ipfs swarm peers should be fast, ipfs pin ls may get really slow for mid-large repos, especially when called without -t recursive flag (mine repo has few 100k's of pins, pin ls can take minutes to finish)

As a workaround until #415 lands we only check for explicit (recursive) ones,
as suggested in #360 (comment)

Closes #360

@lidel
fix: check only for recursive pins
ad84b82 
`pin.ls` may get really slow for mid-range repos,
so we only check for explicit (recursive) ones

Context: #360 (comment)
Closes #360
@lidel lidel merged commit 952e11f into master Sep 24, 2018
@lidel lidel deleted the fix/slow-pin-ls branch September 24, 2018 10:45
@lidel lidel mentioned this pull request Oct 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lidel