Fix port collisions in Brave #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In current implementation the Embedded node uses same config keys as External one. When switching between External and Embedded in Brave we now persist the old (External) config and restore it when user switched back to External node type.
Before starting embedded js-ipfs we now check if API and Gateway ports are free. If not, we find available ones and update the config. This way user does not need to deal with "port taken" errors and embedded node provides seamless experience without surprises.
lidel
force-pushed
the
fix/remember-external-gateway
branch
from
b03f7ea
to
b48e643
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(brave): no port collisions
fix(brave): persist External node config