fix: specify pbjs root #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we do not specify a root for pbjs, the default is used which is shared globally, so we can't have a protobuf message called `Message` that exists for both `ipfs-bitswap` and `libp2p-kad-dht`, for example. Specify a root to add a scope to the declaration of protobuf messages.
achingbrain
commented
Apr 20, 2021
vasco-santos
approved these changes
Apr 20, 2021
…ap into fix/specify-pbjs-root
Yes, every use of pbjs should have a root added as this will bite us again.. |
achingbrain
added a commit
to libp2p/js-libp2p-kad-dht
that referenced
this pull request
Apr 20, 2021
To prevent namespace conflicts with protobuf message names. Refs ipfs/js-ipfs-bitswap#323
achingbrain
added a commit
to ipfs/js-ipfs-unixfs
that referenced
this pull request
Apr 20, 2021
To prevent namespace conflicts with protobuf message names. Refs ipfs/js-ipfs-bitswap#323
achingbrain
added a commit
to achingbrain/js-libp2p-noise
that referenced
this pull request
Apr 23, 2021
- Updates all deps to pull in the latest buffer and bl modules - Specifies a root name for pbjs code gen - message names for pbjs generated code are global so specifying a root name scopes them to prevent two modules accidentally trampling over each other's protobuf code by giving their messages the same name Refs: ipfs/js-ipfs-bitswap#323 BREAKING CHANGE: buffer@6 dropped support for IE and Safari < 10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we do not specify a root for pbjs, the default is used which is
shared globally, so we can't have a protobuf message called
Messagethat exists for both
ipfs-bitswapandlibp2p-kad-dht, for example.Specify a root to add a scope to the declaration of protobuf messages.