Async Crypto Endeavour #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
dignifiedquire
force-pushed
the
webcrypto
branch
from
f7424c5
to
138a3d4
Compare
|
Got all tests passing locally with a small fix to ipfs-repo which I'm creating a PR for now |
|
PR is up: ipfs/js-ipfs-repo#102 |
This was referenced Nov 7, 2016
Closed
|
This is the last giant to defeat in order to finish the Async Crypto PR Mountain :) |
dignifiedquire
force-pushed
the
webcrypto
branch
from
a0ea59b
to
540af9f
Compare
daviddias
reviewed
Nov 11, 2016
| return Boolean(nextTask) | ||
| }, | ||
| (next) => { | ||
| log('generating') | ||
| log('got task', nextTask) |
There was a problem hiding this comment.
two logs next to each other, better coalesce to one
There was a problem hiding this comment.
ahhhh, there I don't wait for you one single time..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.