fix: swap node buffers for uint8arrays #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrades all the datastores to get/put `Uint8Array`s instead of node `Buffer`s. BREAKING CHANGES: - Swaps out node `Buffer`s for `Uint8Array`s
|
Curious here. Since this PR depends on another ones, would you be interested by this Github app that I built that prevents PRs with "Depends on" from being merged before their dependencies ? Do you think it's something that can help you in your projects ? cc @achingbrain |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades all the datastores to get/put
Uint8Arrays instead of nodeBuffers.Depends on:
BREAKING CHANGES:
Buffers forUint8Arrays