feat: add types #275
Merged
feat: add types #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
requested changes
Jan 22, 2021
achingbrain
reviewed
Jan 22, 2021
achingbrain
reviewed
Jan 22, 2021
- adds types - removes fake async - fixes tests for async errors that now are sync - adds local types for merge-options
- split datastore instantiation from opening - add it-pushable types - add just-range types - add proper-lockfile types - fix lock.close we werent waiting for the promise
…stead of InternalOptions
This reverts commit 81d65a3.
|
ready to go |
achingbrain
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
0c911f0 (Hugo Dias, 9 seconds ago)
fix: fix possible undefined datastores
1fba61c (Hugo Dias, 24 hours ago)
feat: base types