Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(chunker-rabin): types and errors are aligned #341

Merged
merged 4 commits into from
Jul 14, 2023
Merged

fix(chunker-rabin): types and errors are aligned #341

merged 4 commits into from
Jul 14, 2023

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Jul 4, 2023

  • test(ipfs-unixfs-importer): chunker-rabin constructor empty args
  • fix(chunker-rabin): types and errors are aligned

fixes #339

@SgtPooki SgtPooki linked an issue Jul 4, 2023 that may be closed by this pull request
bug: rabin chunker errors when no options are passed #339
Closed
whizzzkid
whizzzkid approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@whizzzkid whizzzkid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! minor nit optional

packages/ipfs-unixfs-importer/src/chunker/rabin.ts Outdated Show resolved Hide resolved
@SgtPooki @whizzzkid
chore: pr-nit fix
1e3fe8a 
Co-authored-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>
@SgtPooki SgtPooki requested a review from achingbrain July 6, 2023 20:34
@SgtPooki SgtPooki merged commit df27ff0 into master Jul 14, 2023
17 checks passed
@SgtPooki SgtPooki deleted the 339-bug-rabin-chunker-errors-when-no-options-are-passed branch July 14, 2023 00:15
github-actions bot pushed a commit that referenced this pull request Jul 14, 2023
@semantic-release-bot
chore(release): 15.1.7 [skip ci]
84f9bf7 
## [ipfs-unixfs-importer-v15.1.7](ipfs-unixfs-importer-v15.1.6...ipfs-unixfs-importer-v15.1.7) (2023-07-14)

### Bug Fixes

* **chunker-rabin:** types and errors are aligned ([#341](#341)) ([df27ff0](df27ff0)), closes [#339](#339)
@github-actions
Copy link

🎉 This PR is included in version ipfs-unixfs-importer-v15.1.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whizzzkid whizzzkid whizzzkid approved these changes

@achingbrain achingbrain Awaiting requested review from achingbrain

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: rabin chunker errors when no options are passed
2 participants
@SgtPooki @whizzzkid