Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

bug: use correct version IPFS version number #3622

Closed
lidel opened this issue Apr 12, 2021 · 1 comment
Closed

bug: use correct version IPFS version number #3622

lidel opened this issue Apr 12, 2021 · 1 comment
Assignees
@SgtPooki
Labels
effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) kind/wontfix-migration-available P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked

Comments

@lidel
Copy link
Member

lidel commented Apr 12, 2021 •
edited
Loading

The version number that ipfs.version() outputs should be the one of the release.

Right now it is the version of the ipfs-core package.

Potential solution (TBD):

  • read the latest github release / NPM version of ipfs package at the build time and hardcode it in ipfs-core
@lidel lidel added kind/bug A bug in existing code (including security flaws) exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue status/ready Ready to be worked P2 Medium: Good to have, but can wait until someone steps up good first issue Good issue for new contributors effort/hours Estimated to take one or several hours labels Apr 12, 2021
@lidel lidel mentioned this issue Apr 12, 2021
Closed
@lidel lidel added exp/intermediate Prior experience is likely helpful and removed good first issue Good issue for new contributors exp/novice Someone with a little familiarity can pick up labels Apr 12, 2021
@SgtPooki SgtPooki self-assigned this May 17, 2023
@SgtPooki
Copy link
Member

js-ipfs is being deprecated in favor of Helia. You can #4336 and read the migration guide.

Please feel to reopen with any comments by 2023-06-02. We will do a final pass on reopened issues afterward (see #4336).

This issue is most likely resolved in Helia, please try it out!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@SgtPooki SgtPooki

Labels
effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) kind/wontfix-migration-available P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked
Projects
No open projects
js-ipfs deprecation
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lidel @SgtPooki