This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: use correct version IPFS version number #3534
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version number that `ipfs.version()` outputs should be the one of the release. Prior to this change it was the version of the `ipfs-core` package.
achingbrain
suggested changes
Feb 7, 2021
| @@ -1,6 +1,6 @@ | |||
| 'use strict' | |||
|
|
|||
| const pkg = require('../../package.json') | |||
| const pkg = require('../../../ipfs/package.json') | |||
There was a problem hiding this comment.
This will fail at runtime as it traverses outside of the module folder. E.g. if you only have ipfs-core installed (e.g. your app is running an in-process IPFS node and you don't need a CLI/HTTP API server/daemon, etc).
There was a problem hiding this comment.
A better solution may be to have the build write a version file out at build time with the version number, git hash, etc, then we can try to load it here. It would also mean that the whole package.json doesn't get included in the browser bundle which would be a nice side benefit.
|
Seems this needs more robust solution, let's continue in #3622 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version number that
ipfs.version()outputs should be the oneof the release.
Prior to this change it was the version of the
ipfs-corepackage.This change is powered by the hackweek :)