Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

fix: coerce key gen size to number in CLI #1582

Merged
merged 3 commits into from
Sep 18, 2018
Merged

Conversation

alanshaw
Copy link
Member

@alanshaw alanshaw commented Sep 18, 2018

Keychain params are now validated properly and has caused these test to fail libp2p/js-libp2p-keychain#26

License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
@ghost ghost assigned alanshaw Sep 18, 2018
@ghost ghost added the status/in-progress In progress label Sep 18, 2018
Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Alan Shaw added 2 commits September 18, 2018 14:05
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
@alanshaw alanshaw merged commit 25d820d into master Sep 18, 2018
@alanshaw alanshaw deleted the fix/cli-key-gen-size-type branch September 18, 2018 15:27
@ghost ghost removed the status/in-progress In progress label Sep 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants