This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: use Key.asKey instead of instanceOf #3877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `instanceOf` is not reliable since instances of classes can cross the CLS/ESM boundary and/or come from different browser bundles. Instead see if we can treat what we've been handed as a `Key` by using the `Key.asKey` method. Fixes #3852
This was referenced Apr 8, 2022
This was referenced Oct 30, 2022
This was referenced Oct 30, 2022
This was referenced Oct 30, 2022
This was referenced Oct 30, 2022
This was referenced Oct 31, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
instanceOfis not reliable since instances of classes can cross the CLS/ESM boundary and/or come from different browser bundles.Instead see if we can treat what we've been handed as a
Keyby using theKey.asKeymethod.Fixes #3852