chore: remove peer deps #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We added ipfs, the http client etc as peer deps to signal to the user that they should add the modules they depend on as deps of their project. Starting with npm7 all peer deps get installed automatically which defeats the purpose of our use of peer deps, so let's remove them.
|
Also removes the pre-commit hooks because we don't use them any more, and the thing just caused me to lose a commit message as it errored out trying to run a command. |
hugomrdias
approved these changes
Apr 7, 2021
|
Getting some weird behaviour from yarn while installing deps in CI: |
|
Not massively helpful: yarnpkg/yarn#6312 |
77 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added ipfs, the http client etc as peer deps to signal to the user
that they should add the modules they depend on as deps of their project.
Starting with npm7 all peer deps get installed automatically which
defeats the purpose of our use of peer deps, so let's remove them.