feat: add types #106
Merged
feat: add types #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds ts types, fixes all tsc errors. Removes ipfs/ipfsd-ctl/ipfs-http-client dev deps as we only spin up a node to get an IPFS id which we can just hard code for testing purposes. Replaces protons with protobufjs as elsewhere in the stack.
achingbrain
commented
Mar 5, 2021
| const { parseRFC3339 } = require('./utils') | ||
| const ERRORS = require('./errors') | ||
|
|
||
| const ID_MULTIHASH_CODE = multihash.names.id | ||
| const ID_MULTIHASH_CODE = multihash.names.identity |
There was a problem hiding this comment.
This used to be .id but apparently not flagged as a breaking change: multiformats/js-multihash#66
Also, somehow we don't cover this in the tests 😱
achingbrain
commented
Mar 5, 2021
| @@ -116,7 +118,7 @@ const validate = async (publicKey, entry) => { | |||
| throw errCode(new Error('unrecognized validity format (not an rfc3339 format)'), ERRORS.ERR_UNRECOGNIZED_FORMAT) | |||
| } | |||
|
|
|||
| if (validityDate < Date.now()) { | |||
| if (validityDate.getTime() < Date.now()) { | |||
hugomrdias
reviewed
Mar 5, 2021
hugomrdias
approved these changes
Mar 5, 2021
vasco-santos
approved these changes
Mar 5, 2021
| const { parseRFC3339 } = require('./utils') | ||
| const ERRORS = require('./errors') | ||
|
|
||
| const ID_MULTIHASH_CODE = multihash.names.id | ||
| const ID_MULTIHASH_CODE = multihash.names.identity |
There was a problem hiding this comment.
This used to be .id but apparently not flagged as a breaking change: multiformats/js-multihash#66
Also, somehow we don't cover this in the tests 😱
|
Shipped |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ts types, fixes all tsc errors, updates all deps.
Removes ipfs/ipfsd-ctl/ipfs-http-client dev deps as we only spin up
a node to get an IPFS id which we can just hard code for testing purposes.
Replaces protons with protobufjs as elsewhere in the stack.