fix: replace node buffers with uint8arrays #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGES: - All deps of this module use Uint8Arrays instead of Buffers - value and validity fields of IPNSEntries are now Uint8Arrays instead of Strings as they are `bytes` in the protobuf definition
64 tasks
vasco-santos
requested changes
Aug 13, 2020
src/index.js
Outdated
| @@ -193,7 +196,7 @@ const extractPublicKey = (peerId, entry) => { | |||
| if (entry.pubKey) { | |||
| let pubKey | |||
| try { | |||
| pubKey = crypto.keys.unmarshalPublicKey(entry.pubKey) | |||
| pubKey = crypto.keys.unmarshalPublicKey(Buffer.from(entry.pubKey)) | |||
There was a problem hiding this comment.
Aren't we replacing the Buffers everywhere?
There was a problem hiding this comment.
The underlying crypto libraries do not understand Uint8Arrays and require Buffers :(
But! The user should be able to pass Uint8Arrays to our modules without them exploding.
There was a problem hiding this comment.
This should be updated to use libp2p-crypto@0.18.0, it does use Uint8Array now
| node: { | ||
| path: true, | ||
|
|
||
| Buffer: true |
There was a problem hiding this comment.
Yes, I've updated the file with comments about which modules require the node libs
vasco-santos
approved these changes
Aug 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES:
of Strings as they are
bytesin the protobuf definition