Add comments; Check ctx.Err(); Move import

ipfs · Mar 20, 2019 · 13e417e · 13e417e · GitCop · Mar 20, 2019
1 parent 09cc62e
commit 13e417e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/core/core.go b/core/core.go
@@ -14,7 +14,6 @@ import (
 	"context"
 	"errors"
 	"fmt"
-	"github.com/ipfs/go-ipfs/provider"
 	"io"
 	"io/ioutil"
 	"os"
@@ -30,6 +29,7 @@ import (
 	p2p "github.com/ipfs/go-ipfs/p2p"
 	pin "github.com/ipfs/go-ipfs/pin"
 	repo "github.com/ipfs/go-ipfs/repo"
+	provider "github.com/ipfs/go-ipfs/provider"
 
 	bitswap "github.com/ipfs/go-bitswap"
 	bsnet "github.com/ipfs/go-bitswap/network"

diff --git a/provider/provider.go b/provider/provider.go
@@ -17,7 +17,9 @@ const provideOutgoingWorkerLimit = 8
 
 // Provider announces blocks to the network
 type Provider interface {
+	// Run is used to begin processing the provider work
 	Run()
+	// Provide takes a cid and makes an attempt to announce it to the network
 	Provide(cid.Cid) error
 }
 
@@ -54,6 +56,10 @@ func (p *provider) handleAnnouncements() {
 	for workers := 0; workers < provideOutgoingWorkerLimit; workers++ {
 		go func() {
 			for {
+				if err := p.ctx.Err(); err != nil {
+					log.Warningf("Provider context error: %s", err)
+					return
+				}
 				select {
 				case <-p.ctx.Done():
 					return