-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/api/v0/dns/ fails with "not a valid domain name" error on IPNS DNSLinks #6454
Comments
Hey @Gozala, thanks for the report. Is this a recent change? Do you know of an IPFS version where this last worked? |
@eingenito Sadly I don't know exactly when this has changed, but it definitely used to work in the past. The project that used it has last commit on Feb 22, 2019 & I'm inclined to believe that it worked around then. I also have being using it through IPFS Desktop so I'd say it regressed somewhere between 0.7.0-rc and 0.8. I hope this helps to narrow it down somewhat. |
This should resolve to /ipns/Qm... I'm not sure if this ever worked. Note: If you actually want to resolve it, you can use |
I can confirm this bug, it works fine if the dnslink is /ipfs but does not work if it's /ipns. |
You're correct, this has not been fixed. If you want to resolve a path, I recommend using Ideally, |
I would really enjoy to so this, but I know nothing about Go. I don't think I'm the right one to do this. 😕 |
Up to you. Contributing to OSS projects is one of the best ways to learn a language (https://tour.golang.org/welcome/1). |
The thing is, js-ipfs relies on this to resolve the dns |
For the record, this is still broken in v0.7.0: $ dig +noall +answer TXT _dnslink.seanbehan.dev
_dnslink.seanbehan.dev. 300 IN TXT "dnslink=/ipns/k51qzi5uqu5djnx8xr1du720eheh7fmkehu5ltzkr0ksvvd43v6zfhez9y7o70"
$ ipfs dns -r seanbehan.dev
Error: not a valid domain name Not only it does not work, it also produces invalid error message (domain is valid). I created standalone test case in case someone wants to pick this up: Given DNS TXT record at
Compare: |
I've added a PR that at least shows the domain name where it fails: |
|
Version information:
go-ipfs version: 0.4.18-
Repo version: 7
System version: amd64/darwin
Golang version: go1.11.1
Description:
/api/v0/dns API endpoint no longer seems to work for DNSLinks that have ipns values e.g:
dig +noall +answer TXT _dnslink.ipns.gozala.io _dnslink.ipns.gozala.io. 3600 IN TXT "dnslink=/ipns/QmYhQG9JXYeBF6pL7yafFJfEYcKPp9N8n4aRmYZzU6z47u/"
calling following API call seems to fail:
Public gateway seems to also suffer from the same issue:
The text was updated successfully, but these errors were encountered: