-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/api/v0/dns/pkg.pacman.store false-negative? #7439
Comments
Do we have any outdated ACL for domains which might not include Also: I had the DNS-Link entry directly on the subdomain Which leads to the same result. |
Because I'm having the same problem with my domain (aasg.name), I built v0.6.0-rc7 with a patch to show the domain name with the error: diff --git i/namesys/dns.go w/namesys/dns.go
index 984a27a..738612f 100644
--- i/namesys/dns.go
+++ w/namesys/dns.go
@@ -3,6 +3,7 @@ package namesys
import (
"context"
"errors"
+ "fmt"
"net"
"strings"
@@ -53,7 +54,7 @@ func (r *DNSResolver) resolveOnceAsync(ctx context.Context, name string, options
domain := segments[0]
if !isd.IsDomain(domain) {
- out <- onceResult{err: errors.New("not a valid domain name")}
+ out <- onceResult{err: fmt.Errorf("not a valid domain name: %s", domain)}
close(out)
return out
} which shows that
which is documented:
and also makes this ipfs/ipfs-companion#288. |
Looks like the same issue described in #6454 |
@AluisioASG wrote:
Sounds like an improvement, mind doing a PR? |
@AluisioASG (or @RubenKelevra) mind opening a PR with that one-line change? it will be very useful 🙏 I'm closing this one, let's continue in #6454 (comment) |
Version information:
go-ipfs/0.6.0-rc1/aa16952
Description:
Valid DNSLink
pkg.pacman.store
has a valid DNSLink set up on_dnslink
:Unsure if it is relevant, but the main hostname has TXT record which si not related to DNSLink:
Resolv works
Recursive resolution works fine via
resolve
command:and via
Host
HTTP header on public gateways:/api/v0/dns/ check fails
DNSLink check itself returns false-negative for some reason (both on CLI and HTTP API) 🙃
The text was updated successfully, but these errors were encountered: