User Agent suffix is not set in libp2p

[aschmahmann]

Checklist

• This is a bug report, not a question. Ask questions on discuss.ipfs.io.
• I have searched on the issue tracker for my bug.
• I am running the latest kubo version or have an issue updating.

Installation method

built from source

Version

No response

Config

No response

Description

Create two nodes A and B. Start node A with --user-agent-suffix=foo. On node B run ipfs id <node A id> and see that the suffix is missing 😢.

The implementation in #8419 seems to have been implemented incorrectly and the sharness test "verifying behavior" only tests that the node itself knows about the suffix but not that it broadcasts it.

The issue stems from

kubo/core/node/libp2p/libp2p.go

Line 28 in fdd1965

var UserAgent = simpleOpt(libp2p.UserAgent(version.GetUserAgentVersion()))

where the user agent option is created. While the option is itself a function which will get called and run after the suffix has been processed and SetUserAgentSuffix called, the string passed into libp2p.UserAgent is fetched on package load.

kubo/version.go

Line 34 in fdd1965

func SetUserAgentSuffix(suffix string) {

Any fix that delays the setting of the user agent string until fx has asked for it should be fine. As for testing, I'd recommend using the scenario above to reproduce.

[lidel]

Just found it independently, really unfortunate bug: we had test for this, but it only tested ipfs id of local node :(
Will prepare fix, and p2p test, and include them in 0.18.0-rc1. (done: #9457)

cc probe-lab/network-measurements#24