Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove mplex #10094

Closed
wants to merge 1 commit into from
Closed

feat: remove mplex #10094

wants to merge 1 commit into from

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Aug 22, 2023

Largely based on #10051. Requires #10068.

Boxo was updated with ipfs/boxo#431, which updates go-libp2p, which removed support for mplex.

@hacdias hacdias self-assigned this Aug 22, 2023
@hacdias hacdias marked this pull request as ready for review August 22, 2023 12:31
@hacdias hacdias requested a review from a team as a code owner August 22, 2023 12:31
Copy link
Member

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kill it with 🔥!

@hacdias hacdias mentioned this pull request Aug 22, 2023
2 tasks
@Jorropo
Copy link
Contributor

Jorropo commented Aug 22, 2023

I forgot to update after our yesterday meeting, We will do that in v0.24 for 0.23 we are either gonna use Ethereum's V2 mplex or copy the old impl temporarily in an internal Kubo package.

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @hacdias.
Small documentation tweaks suggested inline, but sgtm (for when we are ready to do this)

core/node/libp2p/smux.go Outdated Show resolved Hide resolved
core/node/libp2p/smux.go Outdated Show resolved Hide resolved
core/node/libp2p/smux.go Outdated Show resolved Hide resolved
docs/changelogs/v0.23.md Outdated Show resolved Hide resolved
docs/config.md Outdated Show resolved Hide resolved
docs/config.md Outdated Show resolved Hide resolved
docs/changelogs/v0.23.md Outdated Show resolved Hide resolved
@hacdias
Copy link
Member Author

hacdias commented Aug 22, 2023

@Jorropo please take that on then. I will keep this PR open until you have that ready, since I need it to test other PRs. We can also re-use it for Kubo 0.24.

Also, this actually fails if we bump Boxo because of the upgrades to go-libp2p 0.30.

Base automatically changed from go-1.20 to master August 22, 2023 13:43
Co-Authored-By: Jorropo <jorropo.pgm@gmail.com>
@hacdias
Copy link
Member Author

hacdias commented Aug 24, 2023

Closing this now. It can be revived when we actually fully remove Mplex the next release.

@hacdias hacdias closed this Aug 24, 2023
@hacdias hacdias deleted the remove-mplex branch August 24, 2023 06:44
@BigLep
Copy link
Contributor

BigLep commented Oct 4, 2023

Full removal of mplex is in #10069

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants