Update go-unixfsnode to 1.8.0 #10141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmwiedemann
force-pushed
the
fuse-issue9044
branch
2 times, most recently
from
da236db
to
0e2d64d
Compare
Fixes ipfs#9044 regression in 0.13.0 FUSE access to some files
aschmahmann
force-pushed
the
fuse-issue9044
branch
from
0e2d64d
to
9115d7d
Compare
Jorropo
reviewed
Sep 25, 2023
Jorropo
force-pushed
the
fuse-issue9044
branch
from
d69a1a3
to
b44e11d
Compare
Jorropo
force-pushed
the
fuse-issue9044
branch
from
b44e11d
to
32c325d
Compare
Jorropo
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Thx a lot for handling this, the debugging you done is awesome, the ultimate way to properly fix this is to add tests too so we can catch theses regressions earlier (self targeted comment, not asking you to write more code).
I've tweaked a bit the error message.
|
You mentioned directory listings in the changelog, but the trouble was (also?) about accessing files >256k that did not fit into one raw block and thus used a protobuf file entry. e.g. |
|
Updated thx #10146 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9044 = regression introduced in 0.13.0 of FUSE access to some files