fix: routing findprovs hangs with no records #10206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Jorropo @hacdias thoughts, does this deserve a specific changelog entry (rather than an auto-generated one)? Seems like this should get cherry-picked for the release too if we're happy with it. |
hacdias
approved these changes
Nov 8, 2023
|
I belive we should fix it so that the semantics are how they used to be. |
|
@Jorropo I do agree (and I think @aschmahmann too as per his comment above), but I think it's a good temporary fix while the rest isn't fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IPNS name resolution fix in kubo v0.22.0 (coming from go-libp2p-routing-helpers libp2p/go-libp2p-routing-helpers#75) resulted in changing the semantics of
Routing.FindProvidersAsyncsuch that it no longer returns a channel before the first result comes back.This is bad, functions that return with channels should generally do so quickly. Here it is particularly bad because the event channel used in DHT queries ends up getting clogged (if there are no providers for the CID) which leads to a deadlock until the context is cancelled.
While this should be fixed in go-libp2p-routing-helpers, this should help for now and seems safe.