Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dockerhub trigger #1698

Merged
merged 1 commit into from
Sep 14, 2015
Merged

Added dockerhub trigger #1698

merged 1 commit into from
Sep 14, 2015

Conversation

Luzifer
Copy link
Member

@Luzifer Luzifer commented Sep 14, 2015

As discussed in #1685 this trigger will fire after the ipfs cmd has been built and trigger a DockerHub build for the jbenet/go-ipfs repo on DockerHub.

Encrypted target was created by using this command:

# echo -n 'https://registry.hub.docker.com/[...]/' | gobuilder-cli --repo=github.com/ipfs/go-ipfs encrypt
Go ahead and type your secret ...
U2FsdGVkX18fMPhIZ3k1QDCwnB49ln6DdyvIH2tDDHxTZi3Q3DQ7AKWllo9KngxwteX2dBFQ2P+jLEBh12PEEqOkN2SePNbMhMtmk/c4siHVAqo5wnf8Utgqob0jB40sobmqNN9X3Y/W2yb72LuGJg==

closes #1685

@GitCop
Copy link

GitCop commented Sep 14, 2015

There were the following issues with your Pull Request

  • Commit: 662a614
    • Invalid signoff. Commit message must end with
      License: MIT
      Signed-off-by: .* <.*>

Guidelines and a script are available to help. Your feedback on GitCop is welcome on this issue.


This message was auto-generated by https://gitcop.com

@jbenet jbenet added the backlog label Sep 14, 2015
License: MIT
Signed-off-by: Knut Ahlers <knut@ahlers.me>
@Luzifer
Copy link
Member Author

Luzifer commented Sep 14, 2015

@jbenet PTAL

@jbenet
Copy link
Member

jbenet commented Sep 14, 2015

thanks @Luzifer

jbenet added a commit that referenced this pull request Sep 14, 2015
@jbenet jbenet merged commit 495827b into ipfs:master Sep 14, 2015
@jbenet jbenet removed the backlog label Sep 14, 2015
@jbenet jbenet deleted the notify_dockerhub branch September 14, 2015 15:13
@jbenet
Copy link
Member

jbenet commented Sep 14, 2015

Did this work?

@Luzifer
Copy link
Member Author

Luzifer commented Sep 14, 2015

Yeah the .gobuilder.yml has some issues:

ERRO[789001] Unable to send notification                   error=invalid padding host=eagle repo=github.com/ipfs/go-ipfs/cmd/ipfs

Might result from OpenSSL encryption…

Possible solutions:

  • Use the dockerhub trigger URL in plain text (just replace encoded blob)
  • Find out why it's complaining

@ghost
Copy link

ghost commented Sep 14, 2015

Could you document the github -> gobuilder -> dockerhub build chain somewhere in the infrastructure.git readme? Nothing fancy, just to have it written down that it exists.

@Luzifer
Copy link
Member Author

Luzifer commented Sep 14, 2015

Used the wrong repo as the encryptor… m( I'm sorry…

@jbenet
Copy link
Member

jbenet commented Sep 14, 2015

no worries! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants