use gx vendored packages instead of godeps ones #2319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whyrusleeping
force-pushed
the
cleanup/gx-godeps
branch
2 times, most recently
from
9946ed7
to
b524b8b
Compare
|
saw this test failure: https://travis-ci.org/ipfs/go-ipfs/jobs/108191449 and was sad because i was sure i fixed it. Then i realized i hadnt rebased this over that fix. 😓 |
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
For the rest of the packages in util, move them to thirdparty and update the references. util is gone! License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
whyrusleeping
force-pushed
the
cleanup/gx-godeps
branch
from
b524b8b
to
d7dab3a
Compare
whyrusleeping
added a commit
that referenced
this pull request
Feb 13, 2016
use gx vendored packages instead of godeps ones
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a few deps from godeps (one at a time, mass dep changes are bad).
It also uses the gx vendored go-ipfs-util instead of the in-repo 'util' package, a few subpackages of util that werent included in go-ipfs-util have been moved to thirdparty.
NOTE:
All packages in thirdparty are prime canidates for being extracted from go-ipfs into their own separate gx packages. I'm leaving them there so that anyone who wants to try out gx has a good clear target of what to do.