Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try to raise ulimit if its too low #2466

Merged
merged 3 commits into from
Apr 7, 2016
Merged

Conversation

whyrusleeping
Copy link
Member

ref #2431

License: MIT
Signed-off-by: Jeromy jeromyj@gmail.com

@daviddias
Copy link
Member

registry-mirror requires more than 1024 files open at the same time (or at least makes IPFS do it), it would be nice if IPFS would increase the limit preemptively before crashing.

@whyrusleeping
Copy link
Member Author

@diasdavid but did it work for you?

@daviddias
Copy link
Member

@whyrusleeping failed with 1024, worked with 4096

@chriscool
Copy link
Contributor

Why is there this last commit merging master into the branch for this PR?
Also maybe there could be some tests to make sure this works or, if not possible, fails gracefully.

@whyrusleeping
Copy link
Member Author

@chriscool thats github being weird... I'm also not sure how to test this. Any ideas?

License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
@whyrusleeping whyrusleeping merged commit 5db8b16 into master Apr 7, 2016
@whyrusleeping whyrusleeping deleted the feat/fd-limit-check branch April 7, 2016 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants