unix-friendly output for 'ipfs dht' commands #2560

hackergrrl · 2016-04-13T22:35:15Z

addresses #2494

whyrusleeping · 2016-04-14T20:18:32Z

Could you add some sharness tests using iptb for these now? Now that the output is relatively friendly, thats a much easier task.

hackergrrl · 2016-04-18T16:45:47Z

cc @RichardLitt

hackergrrl · 2016-04-19T01:58:31Z

@whyrusleeping I'm starting to look at this, but given my understanding of DHTs, tests are going to be very fragile: they're highly timing dependent (read: sleep and crossing our fingers). Checking here to see if you know something I don't about making these deterministic.

whyrusleeping · 2016-04-19T16:48:13Z

they shouldnt be too fragile. I'd go for at least testing findprovs first. Add something on one node, run a findprovs from another and make sure that node shows up.

hackergrrl · 2016-04-19T19:51:57Z

You were right: fragility wasn't a problem here. I guess we're good about setting up DHT population on init + local machine sockets -- awesome!

hackergrrl · 2016-04-20T01:08:59Z

Finally passing! I don't think it liked me running iptb init with --force.

RichardLitt · 2016-04-20T17:16:48Z

!remindme when merged.

RichardLitt · 2016-04-20T17:17:25Z

core/commands/dht.go

-GetValue will return the value stored in the DHT at the given key.
+Outputs the best value for the given key.
+
+There may be several different values for a given key stored in the DHT, so this context 'best' means the record that is most desirable. There is no one metric for 'best': it depends entirely on the key type. For IPNS, 'best' is the record that is both valid and has the highest sequence number (freshest). Different key types can specify other 'best' rules.


...so in this context...

Good catch!

RichardLitt · 2016-04-20T18:18:10Z

@noffle Changes look good, but there's an errant ' and ) now.

hackergrrl · 2016-04-20T19:53:42Z

I see the extra ) but no apostrophe issues. The one on go-ipfs' is intentional (possessive).

RichardLitt · 2016-04-20T19:57:34Z

I would avoid the possessive apostrophe here, a bit confusing. go-ipfs DHT internals works as a compound noun without it.

License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

hackergrrl · 2016-04-20T20:01:06Z

Removed.

whyrusleeping · 2016-04-22T23:43:05Z

test/sharness/t0170-dht.sh

+# ipfs dht findprovs <key>
+test_expect_success 'findprovs' '
+  ipfsi 4 dht findprovs planet >actual &&
+  PEERS=$(wc -l actual | cut -d '"'"' '"'"' -f 1) &&


should check the output here is what we expect.

License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

whyrusleeping · 2016-04-24T00:05:30Z

new tests seem to be failing

License: MIT Signed-off-by: Richard Littauer <richard.littauer@gmail.com>

License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

hackergrrl · 2016-04-25T17:04:40Z

Got it. foo >expected | sort != foo | sort >expected. 😀

* Cleans up 'ipfs dht findpeer' output License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io> * Adds more docs for 'ipfs dht put'. License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io> * Write pretty peer ids for ipfs dht put. License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io> * Writes pretty peer ids for ipfs dht query. License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io> * Suppresses unrecognized event type for FinalPeer. License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io> * Improves helptext on dht commands. License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io> * Adds 'ipfs dht findpeer' sharness test. License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io> * Adds sharness tests for remaining DHT commands. License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io> * Uses bash tests rather than 'test' command. License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io> * Removes commented code. License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io> * Removes unneeded init_ipfs. License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io> * Tweaks iptb setup. License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io> * Tweaks wording on dht 'put' and 'get'. License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io> * Removes extraneous ). License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io> * Removes apostrophe. License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io> * Tests the expected peer addresses. License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io> * Gets peer id using iptb. License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io> * Checks explicitly for common put/findprovs peers. License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io> * Sorts expected/actual findpeer results. License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io> * Fix disconnect argument description License: MIT Signed-off-by: Richard Littauer <richard.littauer@gmail.com> * Fixes sort order in t0170-dht.sh. License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

RichardLitt · 2016-04-29T17:37:42Z

Thanks for this!

hackergrrl mentioned this pull request Apr 13, 2016

unix-friendly output for 'ipfs dht' commands #2494

Open

8 tasks

hackergrrl force-pushed the dht-love branch from 182c441 to 156caf7 Compare April 19, 2016 19:45

hackergrrl force-pushed the dht-love branch from 020a3f3 to fff849b Compare April 20, 2016 00:24

RichardLitt reviewed Apr 20, 2016
View reviewed changes

hackergrrl added 14 commits April 20, 2016 13:00

Cleans up 'ipfs dht findpeer' output

b460b31

License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

Adds more docs for 'ipfs dht put'.

f8f65c1

License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

Write pretty peer ids for ipfs dht put.

99ce497

License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

Writes pretty peer ids for ipfs dht query.

5e43e48

License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

Suppresses unrecognized event type for FinalPeer.

da23b94

License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

Improves helptext on dht commands.

0b0cb36

License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

Adds 'ipfs dht findpeer' sharness test.

e6e8fa2

License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

Adds sharness tests for remaining DHT commands.

ad2264c

License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

Uses bash tests rather than 'test' command.

1f39743

License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

Removes commented code.

2f3bfc8

License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

Removes unneeded init_ipfs.

f239ca7

License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

Tweaks iptb setup.

2768634

License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

Tweaks wording on dht 'put' and 'get'.

f6e8ac9

License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

Removes extraneous ).

74ccf4f

License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

hackergrrl force-pushed the dht-love branch from ba47192 to 74ccf4f Compare April 20, 2016 20:00

Removes apostrophe.

d4a5729

License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

whyrusleeping reviewed Apr 22, 2016
View reviewed changes

hackergrrl added 3 commits April 23, 2016 12:38

Tests the expected peer addresses.

247e0e1

License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

Gets peer id using iptb.

d9c4aff

License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

Checks explicitly for common put/findprovs peers.

26d961f

License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

hackergrrl force-pushed the dht-love branch from b4ccf44 to 26d961f Compare April 23, 2016 19:39

Sorts expected/actual findpeer results.

1fcbd0a

License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

hackergrrl mentioned this pull request Apr 25, 2016

Sprint: April 18 → May 3 ipfs/team-mgmt#104

Closed

RichardLitt and others added 2 commits April 25, 2016 09:27

Fix disconnect argument description

076c430

License: MIT Signed-off-by: Richard Littauer <richard.littauer@gmail.com>

Fixes sort order in t0170-dht.sh.

5ba8dda

License: MIT Signed-off-by: Stephen Whitmore <noffle@ipfs.io>

whyrusleeping merged commit 5d25fc1 into ipfs:master Apr 27, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

unix-friendly output for 'ipfs dht' commands #2560

unix-friendly output for 'ipfs dht' commands #2560

hackergrrl commented Apr 13, 2016

whyrusleeping commented Apr 14, 2016

hackergrrl commented Apr 18, 2016

hackergrrl commented Apr 19, 2016 •

edited

Loading

whyrusleeping commented Apr 19, 2016

hackergrrl commented Apr 19, 2016

hackergrrl commented Apr 20, 2016

RichardLitt commented Apr 20, 2016

RichardLitt Apr 20, 2016

hackergrrl Apr 20, 2016

RichardLitt commented Apr 20, 2016

hackergrrl commented Apr 20, 2016

RichardLitt commented Apr 20, 2016

hackergrrl commented Apr 20, 2016

whyrusleeping Apr 22, 2016

hackergrrl Apr 23, 2016

whyrusleeping commented Apr 24, 2016

hackergrrl commented Apr 25, 2016

RichardLitt commented Apr 29, 2016

unix-friendly output for 'ipfs dht' commands #2560

unix-friendly output for 'ipfs dht' commands #2560

Conversation

hackergrrl commented Apr 13, 2016

whyrusleeping commented Apr 14, 2016

hackergrrl commented Apr 18, 2016

hackergrrl commented Apr 19, 2016 • edited Loading

whyrusleeping commented Apr 19, 2016

hackergrrl commented Apr 19, 2016

hackergrrl commented Apr 20, 2016

RichardLitt commented Apr 20, 2016

RichardLitt Apr 20, 2016

Choose a reason for hiding this comment

hackergrrl Apr 20, 2016

Choose a reason for hiding this comment

RichardLitt commented Apr 20, 2016

hackergrrl commented Apr 20, 2016

RichardLitt commented Apr 20, 2016

hackergrrl commented Apr 20, 2016

whyrusleeping Apr 22, 2016

Choose a reason for hiding this comment

hackergrrl Apr 23, 2016

Choose a reason for hiding this comment

whyrusleeping commented Apr 24, 2016

hackergrrl commented Apr 25, 2016

RichardLitt commented Apr 29, 2016

hackergrrl commented Apr 19, 2016 •

edited

Loading