Implements repository initialization with default config #2581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sivachandran I like this! I think for now, having it work this way is fine, but just as a note for the future, i'd like to be able to pass in partial configs, and have the rest autofilled by the init process. Could you add a sharness test for this either in |
sivachandran
force-pushed
the
default-config
branch
from
faee991
to
d8bca3c
Compare
|
@whyrusleeping Added sharness test t0022-init-default.sh |
sivachandran
force-pushed
the
default-config
branch
from
d8bca3c
to
a52dc15
Compare
| ' | ||
|
|
||
| test_expect_success "ipfs read config succeeds" ' | ||
| export IPFS_DEFAULT_CONFIG=`cat "$IPFS_PATH"/config` |
There was a problem hiding this comment.
don't use export, thats a bash-ism and might not be supported by /bin/sh, Also it might work better to use:
IPFS_DEFAULT_CONFIG=$(cat "$IPFS_PATH/config")
Modified init command to receive default configuration from stdin. The changes enable us to use existing key-pair, datastore configuration while initializing new ipfs node. License: MIT Signed-off-by: Sivachandran <sivachandran.p@gmail.com>
sivachandran
force-pushed
the
default-config
branch
from
a52dc15
to
6989686
Compare
|
@whyrusleeping Updated the sharness |
|
@sivachandran awesome, this all LGTM. thanks! |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified init command to receive default configuration from stdin. The changes enable us to use existing key-pair, datastore configuration while initializing new ipfs node.
License: MIT
Signed-off-by: Sivachandran sivachandran.p@gmail.com
@whyrusleeping