routing: use extracted dht and routing code #3220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @geoah for doing 99% of the work here 👍 💯 👍 ✋ |
|
of course the tests are failing... why? |
|
There were two notification packages, ipfs was subscribing for query results to one, dht was announcing to the other one. #3227 should fix it. |
|
Two minor notes, the following files and directories can be safely removed. They are leftovers the last couple extractions and should not be in use any more.
|
License: MIT Signed-off-by: Jeromy <why@ipfs.io>
License: MIT Signed-off-by: George Antoniadis <george@noodles.gr>
License: MIT Signed-off-by: Jeromy <why@ipfs.io>
whyrusleeping
force-pushed
the
deps/extract-dht
branch
from
b9d313c
to
d0e0123
Compare
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
License: MIT
Signed-off-by: Jeromy why@ipfs.io