fix(core) bootstrap panic #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging to fix the issue, but please let me know if anything looks wrong. |
| package math2 | ||
|
|
||
| // IntMin returns the smaller of x or y. | ||
| func IntMin(x, y int) int { |
There was a problem hiding this comment.
😞 i'm sad that math doesnt have intmin
|
@maybebtc yikes i missed it too :( sorry, i'll be more careful with CR |
ariescodescream
pushed a commit
to ariescodescream/go-ipfs
that referenced
this pull request
Oct 23, 2021
fix: always send the result channel when triggering a refresh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
panic occurred because I made a false assumption that the bootstrap list is greater than the boostrap threshold. This is not true for older clients (that have one bootstrap node) and clients that have manually modified the bootstrap config. Now, a
minis taken to index safely.@jbenet @mappum @whyrusleeping