Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(bitswap) extract notifications #53

Closed
wants to merge 8 commits into from
Closed

refactor(bitswap) extract notifications #53

wants to merge 8 commits into from

Commits on Sep 14, 2014

  1. refactor(bitswap) leverage third-party pubsub lib 

    use a third-party pubsub library for internal communications

Insights:
* Within bitswap, the actors don't need anything more than simple pubsub
behavior. Wrapping and unwrapping messages proves unneccessary.

Changes:
* Simplifies the interface for both actors calling GetBlock and actors
receiving blocks on the network
* Leverages a well-tested third-party pubsub library

Design Goals:
* reduce complexity
* extract implementation details (wrapping and unwrapping data, etc)
from bitswap and let bitswap focus on composition of core algorithms
operations
    Brian Tiger Chow committed Sep 14, 2014
    Configuration menu
    Copy the full SHA
    4ecc078 View commit details
    Browse the repository at this point in the history

  2. refactor(bitswap) meslistener -> notifications

    Brian Tiger Chow committed Sep 14, 2014
    Configuration menu
    Copy the full SHA
    8ce7ff1 View commit details
    Browse the repository at this point in the history

  3. fix(bitswap:notifications) shutdown on bs.Halt()

    Brian Tiger Chow committed Sep 14, 2014
    Configuration menu
    Copy the full SHA
    016fbcb View commit details
    Browse the repository at this point in the history

  4. style(bitswap:notifications) rm explicit returns

    Brian Tiger Chow committed Sep 14, 2014
    Configuration menu
    Copy the full SHA
    437e279 View commit details
    Browse the repository at this point in the history

  5. fix(bitswap:notifications) close chan on Publish

    Brian Tiger Chow committed Sep 14, 2014
    Configuration menu
    Copy the full SHA
    088d3a4 View commit details
    Browse the repository at this point in the history

  6. docs(bitswap:notifications) Subscribe

    Brian Tiger Chow committed Sep 14, 2014
    Configuration menu
    Copy the full SHA
    daa185b View commit details
    Browse the repository at this point in the history

  7. refactor(bitswap:notifications) move, rename 

    add interface
    Brian Tiger Chow committed Sep 14, 2014
    Configuration menu
    Copy the full SHA
    30dd557 View commit details
    Browse the repository at this point in the history

  8. test(bitswap:notifications) check if chan is open

    Brian Tiger Chow committed Sep 14, 2014
    Configuration menu
    Copy the full SHA
    26673cf View commit details
    Browse the repository at this point in the history