p2p/net/swarm: fix connect self problems #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds two checks after a successful conn.Dial * if the remote peer is not who we wanted, close conn * if the remove peer is outselves, close conn (the second is redundant, but the codebase may evolve to end up disabling the first check, so keeping the second in place helps) note: Loopback addresses are actually sent out (they _have to be_, in cases where there are >1 node in the same machine), so many times when trying connections, nodes end up dialing themselves.
|
LGTM, in the future, we may want to 'sort' the address list, with loopback addresses as the last resort, and normal looking ip's first. |
|
@whyrusleeping yeah makes sense. we want good heuristics to pick addrs. sorting is not braindead, so in the future. |
|
LGTM still! 👍 |
jbenet
force-pushed
the
fix-connect-self
branch
from
6779ef3
to
9b4d42f
Compare
jbenet
added a commit
that referenced
this pull request
Jan 13, 2015
p2p/net/swarm: fix connect self problems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two checks after a successful conn.Dial
(the second is redundant, but the codebase may evolve to end up disabling the
first check, so keeping the second in place helps)
note: Loopback addresses are actually sent out (they have to be, in cases
where there are >1 node in the same machine), so many times when trying
connections, nodes end up dialing themselves.