fix: ipfs dag export uses the CoreAPI and respects the offline flag #7753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschmahmann
changed the title
ribasushi
reviewed
Nov 5, 2020
Stebalien
approved these changes
Nov 11, 2020
Comment on lines
608
to
609
| if err != nil && | ||
| !node.IsOnline && | ||
| err == ipld.ErrNotFound { |
There was a problem hiding this comment.
Given that there could be more errors that have nothing to do with being offline (e.g. datastore fetching errors, context cancellations, etc.) and that this was already here doesn't seem like it hurts.
|
Merging since handling import is a little more in depth and we can cover it in a separate PR. |
gammazero
added a commit
that referenced
this pull request
Aug 13, 2024
This commit introduces initial Mode and ModTime support for single filesystem files and webfiles. The ipfs add options --preserve-mode and --preserve-mtime are used to store the original mode and last modified time of the file being added, the options --mode, --mtime and --mtime-nsecs are used to store custom values. A custom value of 0 is a no-op. The preserve flags and custom options are mutually exclusive, if both are provided the custom options take precedence. Majority of of the code was from #7754 written by kstuart Replaces #7753 Closes #6920
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ipfs dag import/exportwere directly using theIpfsNodeinstead of aCoreAPIwhich meant that--offlinedoesn't "automatically" work unless we actually do some manual work inside of the code (i.e.cmdenv.GetNode(env)doesn't do anything special with the offline flag).While we could add some magic there to make this problem less common we could also just move more towards the CoreAPI. This PR attempts that latter.
Note: Draft one has only fixed Export, still need to do Import.
cc @ribasushi