-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/migration ipfs download #8064
Merged
+1,186
−27
Merged
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
bddfa4d
Move ipfsdir.go into separate package
gammazero 0565e80
move defaultFetchLimit to fetcher.go
gammazero b838384
Create IpfsFetcher
gammazero b5aae2c
Use IpfsFetcher to download migrations
gammazero 6963d0c
Check return from connect()
gammazero 5bdef8c
Move ipfsdir pkg back into migrations, and put ipfsfetcher into a sep…
gammazero f65110a
Review changes and more tests
gammazero 806831d
log ipfs fetcher close error
gammazero df9a2ca
Multifetcher only return fetch errors if all fetchers fail
gammazero 0994fba
Read IPFS peers from existing config
gammazero 8a7a4c3
Disable listening for inbound connections
gammazero de0eaba
Download migrations, and add them to IPFS, based on CLI flags.
gammazero f9da061
Read peers from CLI flag instead of from existing config file
gammazero 1e16ba1
fix test
gammazero 18bdb52
Add migrations from temp IPFS node after migration
gammazero 55f239b
Build on go < 1.16
gammazero ac8aa16
fix missed error check
gammazero 890bd7e
Migration temp node listens on any port available
gammazero e5254d2
Configure migration from config and not from CLI flags
gammazero 163c003
check error return
gammazero 9768016
Review changes
gammazero 3a0be4c
Use latest config
gammazero ee577fe
Document Migration config
gammazero 9727b4f
error message formatting
gammazero 7d16a95
manually load the config when migrating
Stebalien 96bad6f
fix: factor the migration file reading code into a function
Stebalien d40d0f1
Move readMigrationConfig into migration.go
gammazero 8d1dbfa
Attempt to read Bootstrap and Peering from config
gammazero 03454b7
Revert to previous multihash version
gammazero bd6646f
Additional unit tests
gammazero 3a4d85e
Update documentation
gammazero 40d412a
Better error messages
gammazero e37896d
Review changes
gammazero File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Multifetcher only return fetch errors if all fetchers fail
- Loading branch information
commit df9a2ca0e1c48b96b289bddd69c413c0809b75a4
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the idea here, to return the error from the last fetcher? We should probably just use something like https://github.com/hashicorp/go-multierror (it's already used in go-ipfs).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Returns list of errors if all fetchers fail. Switched to using
multierror
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI, https://github.com/uber-go/multierr/ nicer in my experience (doesn't matter too much).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
daemon was already using https://github.com/hashicorp/go-multierror. 🤷