Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bubble ErrNotFound improvements #8757

Merged
merged 5 commits into from
Mar 17, 2022
Merged

Bubble ErrNotFound improvements #8757

merged 5 commits into from
Mar 17, 2022

Conversation

hsanjuan
Copy link
Contributor

@hsanjuan hsanjuan commented Mar 2, 2022 •
edited by Jorropo
Loading

Closes #7074

@hsanjuan hsanjuan marked this pull request as ready for review March 2, 2022 17:58
@hsanjuan
Copy link
Contributor Author

hsanjuan commented Mar 2, 2022

@aschmahmann I don't think tests are failing because of me. I have retriggered them in any case.

@hsanjuan
Copy link
Contributor Author

hsanjuan commented Mar 2, 2022

There's an example test failing out and I wonder if it's because the CID it tries to fetch is no longer easily available. I have pinned it on web3.storage. Perhaps that improves things.

@hsanjuan
Copy link
Contributor Author

hsanjuan commented Mar 4, 2022

@aschmahmann can I have green light to tag all the dependencies now?

@aschmahmann
Copy link
Contributor

@hsanjuan this looks good to me. Before merging and tagging in all the dependencies can you make sure those PRs have been reviewed too. They're probably an easy 👍, but sometimes things can slip there too.

If you dump a list of the child PRs in the description it'll be easy to track which are still in need of review.

@hsanjuan hsanjuan mentioned this pull request Mar 7, 2022
Closed
@hsanjuan
Copy link
Contributor Author

hsanjuan commented Mar 7, 2022

@aschmahmann the list is here: #7074 (comment)

@BigLep BigLep linked an issue Mar 10, 2022 that may be closed by this pull request
Tracking: Improving ErrNotFound #7074
Closed
@BigLep BigLep added this to the Best Effort Track milestone Mar 10, 2022
@BigLep
Copy link
Contributor

BigLep commented Mar 11, 2022

@aschmahmann : @Jorropo volunteered to look at / merge these PRs. Are you ok to delegate to him?

@BigLep BigLep requested a review from Jorropo March 15, 2022 18:51
Jorropo
Jorropo approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@Jorropo Jorropo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jorropo
chore: update deps
7c2033f 
The commits has been moved from the PR to master to avoid the deps breaking when github is gonna GC the PR commits.
@Jorropo Jorropo enabled auto-merge March 17, 2022 23:32
@Jorropo Jorropo disabled auto-merge March 17, 2022 23:33
@Jorropo Jorropo enabled auto-merge March 17, 2022 23:33
@Jorropo Jorropo merged commit 09aed2d into master Mar 17, 2022
@Jorropo Jorropo deleted the feat/err-not-found branch March 17, 2022 23:42
@hsanjuan hsanjuan mentioned this pull request Mar 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jorropo Jorropo Jorropo approved these changes

@aschmahmann aschmahmann Awaiting requested review from aschmahmann

Assignees

@hsanjuan hsanjuan

Labels
None yet
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
Best Effort Track
Development

Successfully merging this pull request may close these issues.

Tracking: Improving ErrNotFound
4 participants
@hsanjuan @aschmahmann @BigLep @Jorropo