Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RELEASE_ISSUE_TEMPLATE.md #9213

Merged
merged 18 commits into from
Sep 19, 2022
Merged

Update RELEASE_ISSUE_TEMPLATE.md #9213

merged 18 commits into from
Sep 19, 2022

Conversation

ajnavarro
Copy link
Member

No description provided.

@ajnavarro ajnavarro mentioned this pull request Aug 22, 2022
72 tasks
@BigLep
Copy link
Contributor

BigLep commented Aug 22, 2022

Per 2022-08-22 discussion, the list in https://github.com/ipfs/kubo/blob/master/docs/EARLY_TESTERS.md should be updated (I don't know what to).

@ajnavarro
Copy link
Member Author

@BigLep updating early testers list here: #9218

@@ -70,7 +71,7 @@ Checklist:
- [ ] **Stage 1 - Internal Testing**
- [ ] CHANGELOG.md has been updated
- use [`./bin/mkreleaselog`](https://github.com/ipfs/go-ipfs/tree/master/bin/mkreleaselog) to generate a nice starter list
- [ ] Infrastructure Testing:
- [ ] Infrastructure Testing. Open an issue against https://github.com/protocol/bifrost-infra like https://github.com/protocol/bifrost-infra/issues/2046 but spell out all that we want (gateways, bootstrapper, and cluster)
- [ ] Deploy new version to a subset of Bootstrappers
- [ ] Deploy new version to a subset of Gateways
- [ ] Deploy new version to a subset of Preload nodes
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Collect metrics every day: Specify how to collect these metrics.

@@ -70,7 +71,7 @@ Checklist:
- [ ] **Stage 1 - Internal Testing**
- [ ] CHANGELOG.md has been updated
- use [`./bin/mkreleaselog`](https://github.com/ipfs/go-ipfs/tree/master/bin/mkreleaselog) to generate a nice starter list
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How I make it works:

  • install zsh
  • GO111MODULE=off go get -u github.com/ipfs/kubo
  • Go to $GOPATH/src/ipfs/kubo and execute ./bin/mkreleaselog

@BigLep
Copy link
Contributor

BigLep commented Aug 25, 2022

2022-08-25:

docs/RELEASE_ISSUE_TEMPLATE.md Outdated Show resolved Hide resolved
docs/RELEASE_ISSUE_TEMPLATE.md Outdated Show resolved Hide resolved
@BigLep
Copy link
Contributor

BigLep commented Aug 31, 2022

2022-08-31 items from @ajnavarro and @BigLep discussion:

  1. Add a link from release notes to Discuss post (like we did here: https://github.com/ipfs/kubo/releases/tag/v0.15.0 )
  2. Keep the release notes as trim as possible (removing some of the top headers, like we did here: https://github.com/ipfs/kubo/releases/tag/v0.15.0 )

@ajnavarro
Copy link
Member Author

Ready for review and merge.

Copy link
Contributor

@BigLep BigLep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing any reason to merge this since this is only making it better.

I think there are key things we need address for next time like:

  1. Cleanup the document to bias towards having 1 RC. The current template is from days where we'd go months without releasing which then made it more likely we'd have multiple RCs. I think the document will be cleaner to follow if we assume 1 RC. We can then callout what you do if there are multiple RCs.
  2. Reduce duplication between the content in this issue and items that will be in the release specific changelog.md file. I vote for us just linking to the chanelog.md file from here.

docs/RELEASE_ISSUE_TEMPLATE.md Outdated Show resolved Hide resolved
docs/RELEASE_ISSUE_TEMPLATE.md Outdated Show resolved Hide resolved
docs/RELEASE_ISSUE_TEMPLATE.md Outdated Show resolved Hide resolved
docs/RELEASE_ISSUE_TEMPLATE.md Outdated Show resolved Hide resolved
@ajnavarro ajnavarro merged commit 4f9ba1a into master Sep 19, 2022
@ajnavarro ajnavarro deleted the ajnavarro-patch-1 branch September 19, 2022 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants