Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: require IPNS V2 signatures #9265

Merged
merged 1 commit into from
Sep 20, 2022
Merged

fix: require IPNS V2 signatures #9265

merged 1 commit into from
Sep 20, 2022

Conversation

lidel
Copy link
Member

@lidel lidel commented Sep 12, 2022 •
edited
Loading

This PR makes Kubo ignore V1 signatures when validating IPNS records, and always require V2.

See ipfs/go-ipns#41 for low level details.

Closes #9240

BREAKING CHANGE

  • IPNS Records that do not have V2 but have V1 signature will no longer pass validation, even if V1 is correct. V2 is mandatory to pass validation. See "Record validation" in feat: update IPNS specification specs#319 for details.

lidel
lidel commented Sep 12, 2022
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@lidel lidel self-assigned this Sep 12, 2022
@lidel lidel marked this pull request as ready for review September 12, 2022 20:11
ajnavarro
ajnavarro approved these changes Sep 20, 2022
View reviewed changes
Copy link
Member

@ajnavarro ajnavarro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after updating the library to the final one.

@lidel lidel mentioned this pull request Sep 20, 2022
Closed
@lidel lidel merged commit b6b97d9 into master Sep 20, 2022
@lidel lidel deleted the fix/require-v2-signatures branch September 20, 2022 23:09
@lidel lidel mentioned this pull request Sep 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajnavarro ajnavarro ajnavarro approved these changes

@guseggert guseggert Awaiting requested review from guseggert

Assignees

@lidel lidel

Labels
None yet
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove support for deprecated IPNS records v1
2 participants
@lidel @ajnavarro