Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move the cookie prompt to the bottom #347

Closed

Conversation

davidfcopozo
Copy link

Move cookie prompt to the bottom #341

Changes made

  • Positioned the metrics notification to the bottom as intended
  • Change notification wrapper width units from absolute to relative, which helps with responsiveness consistency
  • Remove the auto margin since justifying the content to the center takes care of centering the content
  • Added a z-index of 1 since the body's content was overlapping the metrics notifications

Before the changes:
IPFS metrics up

After the changes:
IPFS metrics down

@davidfcopozo davidfcopozo requested a review from a team as a code owner December 13, 2022 22:31
@welcome

This comment was marked as resolved.

@SgtPooki
Copy link
Member

SgtPooki commented Jan 9, 2023

@davidfcopozo thanks for putting this together but we've got @djmcquillan taking care of this. Follow #340 for more info. Also see #359 and #358

@SgtPooki SgtPooki closed this Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants