Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gateways): Removing Offending Gateways #443

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

whizzzkid
Copy link
Contributor

Closes: #433

CC: @SgtPooki @BigLep

This doesn't feel sustainable, maybe the need is to evangelize https://badbits.dwebops.pub/ more.

@whizzzkid whizzzkid requested a review from a team as a code owner August 3, 2023 04:59
'https://ipfs.soul-network.com/ipfs/:hash',
'https://ipfs.twdragon.net/ipfs/:hash',
'https://getipfs.com/ipfs/:hash',
'https://storage.web3ph.dev/gw/:hash',
Copy link
Contributor Author

@whizzzkid whizzzkid Aug 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in: #435

Author FYI: @alvin-reyes

Screenshot 2023-08-02 at 10 54 48 PM

@@ -80,8 +79,5 @@ export default [
'https://cthd.icu/ipfs/:hash',
'https://ipfs.tayfundogdas.me/ipfs/:hash',
'https://ipfs.jpu.jp/ipfs/:hash',
'https://ipfs.soul-network.com/ipfs/:hash',
'https://ipfs.twdragon.net/ipfs/:hash',
'https://getipfs.com/ipfs/:hash',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in: #419

Author FYI: @VanVan

Screenshot 2023-08-02 at 10 53 44 PM

@@ -80,8 +79,5 @@ export default [
'https://cthd.icu/ipfs/:hash',
'https://ipfs.tayfundogdas.me/ipfs/:hash',
'https://ipfs.jpu.jp/ipfs/:hash',
'https://ipfs.soul-network.com/ipfs/:hash',
'https://ipfs.twdragon.net/ipfs/:hash',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in: #361

Author FYI: @twdragon

Screenshot 2023-08-02 at 10 52 58 PM

@@ -46,7 +46,6 @@ export default [
'https://ipfs.xoqq.ch/ipfs/:hash',
'http://natoboram.mynetgear.com:8080/ipfs/:hash',
'https://video.oneloveipfs.com/ipfs/:hash',
'http://ipfs.anonymize.com/ipfs/:hash',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in #138

Author FYI: @hybla0

Screenshot 2023-08-02 at 11 14 49 PM

Signed-off-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>
@twdragon
Copy link
Contributor

twdragon commented Aug 3, 2023

@whizzzkid I blocked programmatically case-sensitive CIDs on the gateway, and passed the exclusion request to Google. Hope now the gateway will be considered safe, cause it will support only subdomains. Please wait around 3 days to let Google check the domain

@SgtPooki
Copy link
Member

SgtPooki commented Aug 4, 2023

@whizzzkid it would be nice if we could check a gateway's support of the badbits list

@SgtPooki
Copy link
Member

SgtPooki commented Aug 4, 2023

@aschmahmann @lidel do you have any recommendations here?

@BigLep
Copy link

BigLep commented Aug 4, 2023

Agreed that more badbits usage is a good thing (but obviously each user should choose what is right for them). In 2023 Kuibo will get a primitive in place making it more self-service to consume and use such lists: ipfs/kubo#8492

In terms of determining whether a gateway supports badbits, I think the easiest way to do that is to grab some random CIDs from the list and check what happens when you request them from the gateway.

That said, this browser red screen of death will go away when gateway stats (besides ping) are handled in CI (rather than from each browser). There were plans discussed this week of moving in that direction: https://pl-strflt.notion.site/Gateway-Conformance-Dashboards-10490048436e456d99d40016586a6937#cf9d867edd2043619894e5eab4c36bfc

@twdragon
Copy link
Contributor

twdragon commented Aug 6, 2023

@whizzzkid @SgtPooki @BigLep the gateway domain passed the Google checkup, so we can use it, but it is now supporting only the subdomain addressing schema

@whizzzkid
Copy link
Contributor Author

@twdragon the gateway still results in 403, can you create a separate PR for adding it back?

@twdragon
Copy link
Contributor

twdragon commented Aug 7, 2023

@whizzzkid yes, I will do. Please note that the gateway do not support anymore CID v0 and requires only subdomain-based requests. Is it a problem?

@SgtPooki
Copy link
Member

SgtPooki commented Aug 7, 2023

Please note that the gateway do not support anymore CID v0 and requires only subdomain-based requests. Is it a problem?

That should be fine, subdomain-based requests are more secure

@SgtPooki SgtPooki merged commit 7bf97f5 into master Aug 7, 2023
19 checks passed
@SgtPooki SgtPooki deleted the fix/deceptive-site-warnings branch August 7, 2023 14:55
github-actions bot pushed a commit that referenced this pull request Aug 7, 2023
## [1.6.1](v1.6.0...v1.6.1) (2023-08-07)

### Bug Fixes

* **gateways:** Removing Offending Gateways ([#443](#443)) ([7bf97f5](7bf97f5))
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

🎉 This PR is included in version 1.6.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gateway checker blocked on ipns.co domains
4 participants