cli: libp2p listen addresses #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschmahmann
force-pushed
the
feat/configurable-addrs
branch
2 times, most recently
from
406318d
to
443002f
Compare
hacdias
force-pushed
the
feat/configurable-addrs
branch
from
443002f
to
589e0ae
Compare
hacdias
approved these changes
May 24, 2024
Add a command line argument and default values for the libp2p multiaddr listen addresses. Ref.: https://docs.libp2p.io/concepts/transports/listen-and-dial/
hacdias
force-pushed
the
feat/configurable-addrs
branch
from
589e0ae
to
8f655f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an updated version of #59 that closes #128
While we have holepunching support and might not need public listen addresses having them will make things more robust since we can rely on dialback behavior rather than holepunching. While we can listen on the default addresses having configurability here makes it easier for us to enable limited firewall rules.
Note: we could add announce addresses as well if we wanted, at the moment I've left it out to reduce complexity around announce vs append-announce and since I don't have an immediate need for it (e.g. not announcing DNS names). If others want this we could certainly add it though.