Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support pebble datastore #166

Merged
merged 7 commits into from
Oct 7, 2024
Merged

feat: support pebble datastore #166

merged 7 commits into from
Oct 7, 2024

Conversation

gammazero
Copy link
Contributor

Added cli flags for all peble configuration options. Setting any to the zero-value for the type will cause Pebble's devauld value to be used.

Added cli flags for all peble configuration options. Setting any to the zero-value for the type will cause Pebble's devauld value to be used.
@gammazero gammazero marked this pull request as draft October 2, 2024 16:03
@gammazero gammazero marked this pull request as ready for review October 2, 2024 17:11
@gammazero gammazero requested a review from lidel October 2, 2024 17:12
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! looks sensible enough to do A/B test in staging before continuing. I mainly want to see if Pebble's internal compaction is enough for Rainbow's use case, or do we need to explicitly call it in gc.go

docs/blockstores.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
e2e_test.go Outdated Show resolved Hide resolved
setup.go Outdated Show resolved Hide resolved
gammazero and others added 4 commits October 2, 2024 21:43
Co-authored-by: Marcin Rataj <lidel@lidel.org>
Co-authored-by: Marcin Rataj <lidel@lidel.org>
Co-authored-by: Marcin Rataj <lidel@lidel.org>
@gammazero
Copy link
Contributor Author

gammazero commented Oct 5, 2024

I mainly want to see if Pebble's internal compaction is enough for Rainbow's use case, or do we need to explicitly call it in gc.go

There is no need to explicitly do compaction in a GC cycle with pebble. If there is a very high constant influx of data, and the compaction is not catching up, then tuning parameters can be adjusted as needed.

@lidel lidel merged commit 66b1b97 into main Oct 7, 2024
13 checks passed
@lidel lidel deleted the config-pebble-datastore branch October 7, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants