Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

selector: add tests which are driven by language-agnostic spec fixtures. #231

Merged
merged 2 commits into from
Aug 18, 2021
Merged

selector: add tests which are driven by language-agnostic spec fixtures. #231

merged 2 commits into from
Aug 18, 2021

Commits on Aug 18, 2021

  1. selector: add tests which are driven by language-agnostic spec fixtures. 

    This has been LONG overdue.

It depends on a matching PR to the specs, which is:
ipld/ipld#130 .

It adds the specs+docs repo as a git submodule.
(This may be tetchy to some people, but they Solve Problems.)
If you don't check out the submodule, these tests are just skipped.

It adds github.com/warpfork/go-testmark as a new dependency.
This is what parses the fixture format.  It's nothing special;
the fixture format is also... markdown.  This parser just gives us
a good combination of human readability and machine processability.
    @warpfork
    warpfork committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    f14c21d View commit details
    Browse the repository at this point in the history

  2. Bump testmark to a version that refrains from using any modern go fea… 

    …tures.

(Apparently our CI still tests go1.14 and 1.15, neither of which have...
os.ReadFile, of all the banalities.)
    @warpfork
    warpfork committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    628adb7 View commit details
    Browse the repository at this point in the history