Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

schema: enable inline types through dsl parser & compiler #404

Merged
merged 3 commits into from
Apr 26, 2022
Merged

schema: enable inline types through dsl parser & compiler #404

merged 3 commits into from
Apr 26, 2022

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Apr 26, 2022

PR to ipld/ipld coming up after this for fixtures

This lets the schema parser parse things like:

  type LinkMap {String:&Boom}
  type MapMap {String:{String:Boom}}
  type ListMap {String:[Boom]}

enabled for links, maps, structs, keyed and kinded unions, for inline maps, lists and links (which have their own awkwardness)

@rvagg rvagg requested a review from willscott April 26, 2022 07:54
@rvagg rvagg mentioned this pull request Apr 26, 2022
Merged
@rvagg
Copy link
Member Author

rvagg commented Apr 26, 2022

ipld/ipld#211

willscott
willscott approved these changes Apr 26, 2022
View reviewed changes
schema/dmt/compile.go Outdated Show resolved Hide resolved
@rvagg rvagg merged commit 0c00a93 into master Apr 26, 2022
@rvagg rvagg deleted the rvagg/dsl-inline-types branch April 26, 2022 23:51
rvagg added a commit that referenced this pull request Apr 27, 2022
@rvagg
schema: enable inline types through dsl parser & compiler (#404)
a6ca7b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willscott willscott willscott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rvagg @willscott