Types & latest multiformats #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
77 tasks
vmx
reviewed
Apr 12, 2021
There was a problem hiding this comment.
I tried it a bit on my unixfs work. Though I didn't get far as my code currently expects the PBNode to have Data and Links as mandatory fields. Though this is correct. When I look at the decode() (
Line 249 in e6f1eca
Links is mandatory. Which is fine (and I think correct), I just would need to adapt my code in unixfs, which I currently don't have the time to.
Though I think this PR is good and should be merged and released. Once that one, the js-dag-cbor one and the js-multiformats are merged and released, we can revisit my unixfs code.
|
updated to match latest, simplified form of the |
This was referenced Apr 22, 2021
BREAKING CHANGE: * use multiformats@7 and its non-default exports and updated types * export types based on latest multiformats structure * publish with "main" Unlikely to be breaking in practice for anyone not using types, may not even break for those using types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's two commits here, the first one is the interesting one, the second is a temporary commit that includes dist/ in this branch for use with gitpkg and will be removed before merge. This also needs docs updated I think.
This mirrors work done in ipld/js-dag-cbor#18, introducing full type checking and generation to the process. Also builds on multiformats/js-multiformats#75 which has the
CodecFeaturetype that I'm trying out.Can be consumed as a dependency with gitpkg via:
npm install 'https://gitpkg.now.sh/ipld/js-dag-pb/dist?rvagg/types'.Another outstanding TODO is to loosen up the parsing rules to match the recent work done in go-codec-dagpb (ipld/go-codec-dagpb#26) and the spec (ipld/specs#360). There's a fixture block to test that too which should be pulled in.