Return content not found error when HTTP publisher responds with 404 #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The entry chunks for which content is not found are skipped by the indexer. In HTTP publisher, non-existing content returns 404. However, the error returned by the syncer does not allow the "content not found" error to bubble up to ingest pipeline. Therefore, the indexer cannot skip such CIDs from HTTP publishers. In HTTP Syncer check the response status code and if 404 return relevant errors for upstream error handling. Relates to: - ipni/storetheindex#1771
gammazero
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The entry chunks for which content is not found are skipped by the indexer. In HTTP publisher, non-existing content returns 404. However, the error returned by the syncer does not allow the "content not found" error to bubble up to ingest pipeline. Therefore, the indexer cannot skip such CIDs from HTTP publishers.
In HTTP Syncer check the response status code and if 404 return relevant errors for upstream error handling.
Relates to: