DHClient can have a dhstore URL or API #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DHashClient can be given a dhstore API interface when the client within dhstore, This is so that dhstore can give it a set of internal functions to call to do dh multihash and metadata lookups. Otherwise, a client that is not in dhstore uses the dhstore URL to perfrom remote dhstore lookups.
Codecov ReportPatch coverage has no change and project coverage change:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #71 +/- ##
==========================================
+ Coverage 53.73% 53.74% +0.01%
==========================================
Files 61 62 +1
Lines 4757 4778 +21
==========================================
+ Hits 2556 2568 +12
- Misses 1920 1929 +9
Partials 281 281
☔ View full report in Codecov by Sentry. |
masih
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DHashClient can be given a dhstore API interface when the client within dhstore, This is so that dhstore can give it a set of internal functions to call to do dh multihash and metadata lookups. Otherwise, a client that is not in dhstore uses the dhstore URL to perfrom remote dhstore lookups.
Fixes #52