Decouple announce Senders from Publishers #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no strong reason to associate a set of announce Senders with a Publisher. The only association is that a Sender is often used to after updating the Sublisher's head CID. By separating these, it allows more flexibility in where in handling serving an advertisement chain is done and where sending advertisement announcements is done.
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## main #88 +/- ##
==========================================
- Coverage 53.64% 53.48% -0.17%
==========================================
Files 65 65
Lines 5244 5155 -89
==========================================
- Hits 2813 2757 -56
+ Misses 2131 2106 -25
+ Partials 300 292 -8
☔ View full report in Codecov by Sentry. |
masih
approved these changes
Jul 24, 2023
|
This is so much better, thank you :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no strong reason to associate a set of announce Senders with a Publisher. The only association is that a Sender is often used after updating the Sublisher's head CID. Separating these allows more flexibility in choosing where serving an advertisement chain is done and where sending advertisement announcements is done.
Fixes #87