Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Having announce.Receiver is optional for Subscriber #89

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

gammazero
Copy link
Collaborator

It is not always necessary to have an announcement receiver driving the Subscriber, such as when it is used within a CLI to get advertisements on-demand only. Making it optional avoids the setup time and possible unwanted automated behaviors that result from having the announcement receiver enabled.

@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2023

Codecov Report

Patch coverage: 61.70% and project coverage change: -0.48% ⚠️

Comparison is base (2f35326) 53.65% compared to head (bc1be6e) 53.18%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
- Coverage   53.65%   53.18%   -0.48%     
==========================================
  Files          65       65              
  Lines        5155     5148       -7     
==========================================
- Hits         2766     2738      -28     
- Misses       2097     2117      +20     
- Partials      292      293       +1     
Files Changed Coverage Δ
announce/option.go 70.37% <ø> (-18.52%) ⬇️
dagsync/option.go 43.15% <37.50%> (-2.30%) ⬇️
announce/receiver.go 70.18% <63.63%> (-2.76%) ⬇️
dagsync/subscriber.go 76.45% <67.85%> (-0.70%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gammazero gammazero requested a review from masih July 25, 2023 16:10
@gammazero gammazero merged commit e96a786 into main Jul 25, 2023
16 checks passed
@gammazero gammazero deleted the recv-announce-optional branch July 25, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants