Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to register Raw codec to support cid.Raw #92

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Conversation

gammazero
Copy link
Collaborator

@gammazero gammazero commented Jul 26, 2023

The Raw codec was previously registered by other packages used in projects that depended on go-libipni, so the problem was not previously seen. Now that the codec is not registered by those packages, projects using go-libipni fail with the error:

could not choose a decoder: no decoder registered for multicodec code 85 (0x55)

when encountering advertisements with CIDs that use cid.Raw. Registering the Raw codec fixes this.

@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.05% 🎉

Comparison is base (4afec9f) 54.34% compared to head (1d8654c) 54.40%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
+ Coverage   54.34%   54.40%   +0.05%     
==========================================
  Files          65       65              
  Lines        5150     5150              
==========================================
+ Hits         2799     2802       +3     
+ Misses       2048     2045       -3     
  Partials      303      303              
Files Changed Coverage Δ
ingest/schema/schema.go 66.66% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gammazero gammazero merged commit 6990b32 into main Jul 26, 2023
7 checks passed
@gammazero gammazero deleted the register-raw-codec branch July 26, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants